Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMLHttpRequest withCredentials defaults to "true" in ReactNative #1101

Closed
soulwu opened this issue Sep 26, 2017 · 1 comment
Closed

XMLHttpRequest withCredentials defaults to "true" in ReactNative #1101

soulwu opened this issue Sep 26, 2017 · 1 comment

Comments

@soulwu
Copy link

soulwu commented Sep 26, 2017

https://github.com/mzabriskie/axios/blob/07a7b7c84c3ea82ea3f624330be9e0d3f738ac70/lib/adapters/xhr.js#L132-L134
Only set withCredentials value for config.withCredentials is true

For ReactNative, XMLHttpRequest withCredentials defaults to "true"
facebook/react-native@9b4a644

So, I can't set XMLHttpRequest withCredentials to false
@robaxelsen
Copy link
Contributor

Hi @soulwu, thanks for submitting your issue. If you're still experiencing a need for this feature, please submit PR that handles this.

@kmagiera kmagiera mentioned this issue Mar 28, 2018
Closed
@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating xhr adapter to inherit withCredentials flag from the config
2 participants
@soulwu @robaxelsen