Axios 0.19.0 issue

[sm2017]

Describe the bug
I have problem with axios 0.19.0 , my code works well with axios 0.18.0 , I think axios 19 has issue with baseUrl config

To Reproduce

https://runkit.com/sm2017/5d748f34dda96b001a60f5d0

var axios = require("axios")

const instance = axios.create({
  baseUrl:'https://github.com/axios',
});

await instance.get('/axios');

Error: connect ECONNREFUSED 127.0.0.1:80
A stack trace for this error could not be retrieved because stack was already called.

Expected behavior
It must load axios github page

Environment:

• Axios Version [e.g. 0.18.0] 0.0.19
• OS: [e.g. iOS 12.1.0, OSX 10.13.4] , windows 10
• Browser [e.g. Chrome, Safari] nodejs
• Browser Version [e.g. 22] v10.15.3
• Additional Library Versions [e.g. React 16.7, React Native 0.58.0] I test in react native 0.60.5 too

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

[sm2017]

Reply please

[dingziqi]

It's a case problem.Use baseURL。

[lcsvcn]

I am having same issue:

const test= axios.create({
  baseURL: CONSTANTS.BASEURL,
  headers: {
    Accept: 'application/json',
    'Content-Type': 'application/json',
  },
  auth: {
    username: CONSTANTS.USERNAME,
    password: CONSTANTS.PASSWORD
  },
  timeout: 10000,
});

axios.all([
         test.get('path1/'),
          test..get('path2/')
]).then(axios.spread((path1, path2) => {
             // success code
})
).catch((path1, path2) => {
         // error code
});

on 0.18.0 it goes inside success code

on 0.19.0 it goes inside error code

[cesar18pena]

@sm2017 it is just a typo error, should be:

const instance = axios.create({
  baseURL:'https://github.com/axios',
});

instead of

const instance = axios.create({
  baseUrl:'https://github.com/axios',
});

[sm2017]

@dingziqi , @cesar18pena what do you think about the following codes

var axios = require("axios@0.18.0")

const instance = axios.create({
  baseURL:'https://postman-echo.com/',
  url:'/get',
  params:{
    "foo1": "bar1",
    "foo2": "bar2"
  }
});

const {data} = await instance.request();

console.log(data)

var axios = require("axios")

const instance = axios.create({
  baseURL:'https://postman-echo.com/',
  url:'/get',
  params:{
    "foo1": "bar1",
    "foo2": "bar2"
  }
});

const {data} = await instance.request();

console.log(data)

https://runkit.com/embed/nzbzdjc4auv7 works well but https://runkit.com/embed/lro4kcp7w8ir not

[sm2017]

Any idea?

[dingziqi]

The rule of merge config is changed in 0.19.0,(see https://github.com/axios/axios/blob/master/lib/core/mergeConfig.js), the params, url in axios is dropped.

[sm2017]

So it is a brwaking change

[yasuf]

I think I figured out why, there was a change with defaults inside .request that makes it so that the default headers aren't set, I'll try to push a PR to fix this whenever I get a chance, relevant lines:

0.18 version

axios/lib/core/Axios.js

Line 35 in face016

config = utils.merge(defaults, {method: 'get'}, this.defaults, config);

0.19 version

axios/lib/core/Axios.js

Line 37 in bbfd5b1

config = mergeConfig(this.defaults, config);

good catch!

[yasuf]

@sm2017 can you test if the request works with this change? #2516

[chinesedfan]

Tested with 0.19.1, and it works.