Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflate/gunzip #23

Closed
OliverJAsh opened this issue Nov 5, 2014 · 5 comments
Closed

Deflate/gunzip #23

OliverJAsh opened this issue Nov 5, 2014 · 5 comments

Comments

@OliverJAsh
Copy link

It would be nice to see support for deflating/gunzipping requests. Have you thought about this?

@mzabriskie
Copy link
Member

It's a great idea, though not at the top of my list for the roadmap. Would welcome a PR if you want to take a stab at it.

@jimthedev
Copy link

Looks like http://nodeca.github.io/pako/ does exactly this. Perhaps it would be worth figuring out if the two can work together so as to keep as much as possible outside of axios core.

@mzabriskie
Copy link
Member

@jimthedev thanks for the tip. I'll take a look at it.

@mzabriskie
Copy link
Member

@jimthedev @OliverJAsh I think I would recommend keeping this functionality out of axios. I want to keep the bloat down as much as possible from the core. Minified pako is 44k vs axios minified is 15k. Should be able to easily create an interceptor to inflate/deflate requests as needed.

@jimthedev
Copy link

Sounds good.

On Sun, Jan 25, 2015 at 3:21 PM, Matt Zabriskie notifications@github.com
wrote:

@jimthedev https://github.com/jimthedev @OliverJAsh
https://github.com/OliverJAsh I think I would recommend keeping this
functionality out of axios. I want to keep the bloat down as much as
possible from the core. Minified pako is 44k vs axios minified is 15k.
Should be able to easily create an interceptor to inflate/deflate requests
as needed.


Reply to this email directly or view it on GitHub
#23 (comment).

@axios axios locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants