Reject with error

[OliverJAsh]

It is good practice to reject promises with an error object because they have stack traces.

When rejecting because of a bad status code, I suggest rejecting with an error object, e.g. BadStatusCodeError. You could then attach the response object to the error object so it can be accessed in a rejection handler.

[jtmarmon]

+1 would love to be able to use this in tests

[jtmarmon]

see #32

[kilianc]

+1 on this, I was just about to open a new issue, throwing non errors is wrong, and if you async or yield axios that's exactly what happens.

This is for some reason not part of the promises specification, and it's a flaw imho.

[trueter]

+1

[helmus]

👍 Please raise the priority on this. This is not a feature, it's a bug.

[naw]

It's possible to address this without breaking backward compatibility simply by making it configurable with a default that uses the current (legacy) behavior. Then, for a major release, you can simply change the default from the legacy behavior to the new behavior.

[kilianc]

@naw this is a bug fix not a feature change. It may make sense to be more conservative and bump minor. I hope the old behavior just goes away

[axross]

👍

[trueter]

Its been a month, can we please have this?