Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blindly use JSON.parse when transforming response data #55

Closed
mzabriskie opened this issue Apr 8, 2015 · 0 comments
Closed

Blindly use JSON.parse when transforming response data #55

mzabriskie opened this issue Apr 8, 2015 · 0 comments

Comments

@mzabriskie
Copy link
Member

Perf isn't that much better using RegExp before hand to determine if String is JSON. This also causes problems b/c YAML can look like JSON in some cases, but throws an Exception when attempting to parse. If using try/catch is needed for the second case anyway, just abandon the RegExp all together.

Benchmarks: https://gist.github.com/mzabriskie/fe85e6ea69b5049d17dd

@axios axios locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant