Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEFAULT_WAIT_DELAY probably too big #16

Closed
nonmanifold opened this issue Dec 27, 2016 · 4 comments
Closed

DEFAULT_WAIT_DELAY probably too big #16

nonmanifold opened this issue Dec 27, 2016 · 4 comments

Comments

@nonmanifold
Copy link

Individual tests are taking too long to complete, and I have to set delay to zero manualy.
Maybe it's better to set this delay to 0 by default?

@msakrejda
Copy link

+1. Alternately, is there some way to explicitly indicate to moxios that we expect all the requests to have been made instead of using a timeout? Our (default) mocha setup flags all our axios tests as taking too long, because mocha's slow test threshold is also around 100ms.

@msakrejda
Copy link

We ended up dropping moxios because of this. We've moved to mocking our axios calls with testdouble using td.replace and td.when on methods like axios.get. It's not as elegant but it's a lot faster.

hovissimo added a commit to hovissimo/moxios that referenced this issue Mar 26, 2018
This works fine and massively improves my test run speed. See Issue axios#16
hovissimo added a commit to hovissimo/moxios that referenced this issue Mar 26, 2018
This works fine and massively improves my test run speed. See Issue axios#16
@hovissimo
Copy link
Contributor

Please see #48

anilanar referenced this issue in anilanar/moxios May 27, 2018
This works fine and massively improves my test run speed. See Issue #16
mzabriskie added a commit that referenced this issue Mar 21, 2019
Update DEFAULT_WAIT_DELAY to 1 per #16
@mzabriskie
Copy link
Member

Fixed with #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants