Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua 5.2 support #146

Closed
devurandom opened this issue Sep 16, 2012 · 4 comments
Closed

Lua 5.2 support #146

devurandom opened this issue Sep 16, 2012 · 4 comments

Comments

@devurandom
Copy link
Contributor

lsyncd-2.0.7 fails to compile with Lua 5.2, see for example the Gentoo bug on the matter [1].

The error is:
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -pipe -O2 -march=athlon64-sse3 -Wall -c inotify.c
inotify.c:132:1: error: unknown type name ‘luaL_reg’
[…]

A complete build.log is available at abovementioned report.

[1] https://bugs.gentoo.org/show_bug.cgi?id=434238

@axkibe
Copy link
Collaborator

axkibe commented Sep 18, 2012

Thank you. I'll cater for this in upcoming Lsyncd 2.1

devurandom added a commit to devurandom/lsyncd that referenced this issue Sep 18, 2012
@devurandom
Copy link
Contributor Author

I created a patch and submitted it as pull #147.

@axkibe
Copy link
Collaborator

axkibe commented Sep 18, 2012

Thank you, will look through it at the weekend.
Don't you think it would be possible to write it in a way it works with 5.1
and 5.2?
Kind regards, Axel

On Tue, Sep 18, 2012 at 3:25 PM, Dennis Schridde
notifications@github.comwrote:

I created a patch and submitted it as pull #147#147
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/146#issuecomment-8654563.

@axkibe
Copy link
Collaborator

axkibe commented Sep 18, 2012

If I remember correctly from the mailinglist, there is some backward
compatibility flag in Lua 5.2 to turn on before including the header file,
this time they turned it off by default. It will create backward
compatilibity with Lua 5.1, but not what has been been deprecated in 5.1
already. However, in 5.1 they had the compatibility flag for 5.0 turned on
by default, so maybe Lsyncd uses 5.0 stuff. If thats the case it should be
changed to 5.1 native code, that works with 5.2 compatibility flag turned
on. I don't expect a 5.3 or 6.0 in any near or middle future, see:
http://lua-users.org/lists/lua-l/2011-12/msg00579.html

Thank you, for your effort! Its great work.

Kind regards, Axel
.

On Tue, Sep 18, 2012 at 3:39 PM, Axel Kittenberger axkibe@gmail.com wrote:

Thank you, will look through it at the weekend.
Don't you think it would be possible to write it in a way it works with
5.1 and 5.2?
Kind regards, Axel

On Tue, Sep 18, 2012 at 3:25 PM, Dennis Schridde <notifications@github.com

wrote:

I created a patch and submitted it as pull #147#147
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/146#issuecomment-8654563.

devurandom added a commit to devurandom/lsyncd that referenced this issue Oct 1, 2012
devurandom added a commit to devurandom/lsyncd that referenced this issue Oct 2, 2012
devurandom added a commit to devurandom/lsyncd that referenced this issue Oct 2, 2012
devurandom added a commit to devurandom/lsyncd that referenced this issue Oct 2, 2012
Use Lua 5.2 API without compatibility code
devurandom added a commit to devurandom/lsyncd that referenced this issue Dec 1, 2012
Use Lua 5.2 API without compatibility code
devurandom added a commit to devurandom/lsyncd that referenced this issue Feb 26, 2013
Use Lua 5.2 API without compatibility code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants