Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross compile aarch64-apple-darwin by default #133

Closed
ashleygwilliams opened this issue Feb 16, 2023 · 5 comments · Fixed by #172
Closed

cross compile aarch64-apple-darwin by default #133

ashleygwilliams opened this issue Feb 16, 2023 · 5 comments · Fixed by #172
Milestone

Comments

@ashleygwilliams
Copy link
Member

because this is made dead simple by apple (we need only add the target), i think we should include compiling to aarch64-apple-darwin by default, ahead of any larger cross compilation story (which will require more configuration and tooling)

this plus #82/#100 will bring us to target parity with a lot of folks looking to migrate to using cargo-dist

@ashleygwilliams ashleygwilliams added this to the next milestone Feb 16, 2023
@ashleygwilliams ashleygwilliams added the feature request New feature or request label Feb 16, 2023
@Gankra
Copy link
Member

Gankra commented Feb 16, 2023

Some notes on this in #77, as this issue is a logical subtask of it.

@ashleygwilliams
Copy link
Member Author

/me nods

my preference would be for us to do this first, since it is very simple and browser detection of arch is something we know how to do. i think the fat binary idea is interesting, but it feels much less impactful and generally more complicated to implement to me than building this target independently, if that makes sense?

@Gankra
Copy link
Member

Gankra commented Feb 16, 2023

oh absolutely, i was just literally linking it for the notes

@frol
Copy link
Contributor

frol commented Feb 19, 2023

For those interested in this issue, I have submitted PR #143 to address this issue.

@Gankra
Copy link
Member

Gankra commented Mar 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants