Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Symbol Support #136

Open
Gankra opened this issue Feb 16, 2023 · 0 comments
Open

Rework Symbol Support #136

Gankra opened this issue Feb 16, 2023 · 0 comments
Labels
feature request New feature or request

Comments

@Gankra
Copy link
Member

Gankra commented Feb 16, 2023

I've disabled all symbols pending this redesign of the feature, due to several issues:

I propose two fixes:

Fix 1: We shouldn't consider it a hard error to fail to generate a pdb

This creates an awkward situation with manifest --artifacts=all, due to a lack of #45. I think rather than "solving" #45 we should just add an optional: true field to dist-manifest.json indicating the symbols artifacts are ok to fail. Then we should also change cargo dist build to silently remove optional: true entries from its output if they indeed failed (preventing CI from trying to upload nothing). Someone reading dist-manifest.json then just needs to accept that they might fail to fetch those (seems fine).

Fix 2: We should unconditionally wrap every kind of symbol file in a zip

That will allow us to preserve the name rustc/cargo told us was the Right one. This will handle the most important aspects of #116, which is getting the symbols to a server/user with the right name. The consumer of such a zip just needs to understand they have to properly spider the folder. Ideally each folder will contain one entry.

I'm not 100% sure what to name the zips and the folders they contain. This is most awkward for blah.dSYM because we want blah-v1.0.0-x86_64-apple-darwin.dSYM.tar.xz to contain a dir containing the .dSYM but if we just name the dir blah-v1.0.0-x86_64-apple-darwin.dSYM things might freak out and think it's an actual dSYM (because those are dirs!). Maybe just call the inner dir blah-v1.0.0-x86_64-apple-darwin-dSYM? Are tar and zip happy with that kind of rename? I think so?

@Gankra Gankra added the feature request New feature or request label Feb 16, 2023
@Gankra Gankra added this to the debuginfo-ready milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant