Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifact-download-url customization #236

Open
Gankra opened this issue May 3, 2023 · 2 comments
Open

artifact-download-url customization #236

Gankra opened this issue May 3, 2023 · 2 comments
Labels
feature request New feature or request
Milestone

Comments

@Gankra
Copy link
Member

Gankra commented May 3, 2023

Currently we only support hardcoded support for github artifact download urls, which makes installers gated behind github. We can solve this by just letting the user specify. This should possibly support some amount of templating, as seen in the config for cargo-binstall.

It might also help github enterprise users.

Theoretical usecases:

  • artifact-download-url = "{repo}/releases/downloads/{tag}/" (what we currently do for github)
  • artifact-download-url = "https://mywebsite.com/{tag}/"

Exposing things like "app-name" and "app-version" are sketchier with workspaces but we can maybe allow them for single-app workspaces?

@Gankra Gankra added the feature request New feature or request label May 3, 2023
@Gankra Gankra added this to the 0.1.0 milestone May 3, 2023
@ashleygwilliams
Copy link
Member

interesting. this feels complicated- but complicated is fine if the end users are advanced. can we offer a way for an end user to validate/test what they've set up?

@Gankra
Copy link
Member Author

Gankra commented Jul 20, 2023

Ideally this would use the same solution we pick for axodotdev/oranda#507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants