Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't mess up release note generation if there are multiple releases #69

Closed
Gankra opened this issue Jan 31, 2023 · 1 comment · Fixed by #115
Closed

don't mess up release note generation if there are multiple releases #69

Gankra opened this issue Jan 31, 2023 · 1 comment · Fixed by #115
Labels
bug Something isn't working

Comments

@Gankra
Copy link
Member

Gankra commented Jan 31, 2023

really we just don't handle multiple releases properly at all, but I'm pretty sure something funky will happen to the release note generation code/scripts if there are multiple. Possibly they'll end up concatenated? Or one will get picked arbitrarily?

Ideally you workflow either looks like:

  • I am cutting a unified release for everything in the workspace, merge the release notes harmoniously
  • I am cutting N logically independent releases at once, create N github releases with their own ntoes
  • I am cutting a release for only one the projects in the workspace

The last 2 may actually end up looking the same, as you may just push N commits with tags like "specific-app-vX.Y.Z". This kind of pattern isn't at all handled by the CI scripts though (but I'd like it to be!). But if we're adding that kind of complex parsing/detection of the git tag, I'd like that logic to somehow live in cargo-dist itself (no complex logic in CI scripts!!!).

@Gankra
Copy link
Member Author

Gankra commented Feb 8, 2023

working on a more holistic fix to this in #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant