Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository of git+https causes panic #531

Closed
geelen opened this issue Jul 18, 2023 · 0 comments · Fixed by #563
Closed

Repository of git+https causes panic #531

geelen opened this issue Jul 18, 2023 · 0 comments · Fixed by #563

Comments

@geelen
Copy link

geelen commented Jul 18, 2023

With the following repository value in my package json:

  "repository": {
    "type": "git",
    "url": "git+https://github.com/geelen/zest.git"
  },

I got the following output:

pnpm oranda build
↪ >o_o< INFO: Running build...
  × oranda panicked.
  ├─▶ at src/data/github/repo.rs:37:13
  ╰─▶ not yet implemented
  help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.
RUST_BACKTRACE=1 pnpm oranda build
↪ >o_o< INFO: Running build...
  × oranda panicked.
  ├─▶ at src/data/github/repo.rs:37:13
  ╰─▶ not yet implemented
         0: 0x101668b94 - _rust_begin_unwind
         1: 0x10177edf0 - core::panicking::panic_fmt::hc7e96873bfc1c7ba
         2: 0x10177ee60 - core::panicking::panic::h3a764673a10f87a9
         3: 0x1012d9224 - oranda::data::github::repo::GithubRepo::from_url::hee13a14a73529eb2
         4: 0x1012c3dd8 - oranda::site::Site::build::hd1917d5f070cb178
         5: 0x1013f3d44 - oranda::commands::build::Build::run::h6e6bcc81518a3df3
         6: 0x1013dd4c8 - oranda::run::hdae61ada1dad0b71
         7: 0x101414600 - axocli::CliAppBuilder::start::h28edfc121d4f9a87
         8: 0x1013dd0ac - oranda::main::h7f97a2f9cf119a6b
  help: set the `RUST_BACKTRACE=1` environment variable to display a backtrace.

Changing my package json to use the github shorthand fixed it:

  "repository": "github:geelen/zest",

The problem is mainly the lack of breadcrumbs for tracking down the error. Getting just a not yet implemented, without a description, meant I went looking through my README.md and trying to figure out if it was something related to the links in there, before I thought to look in package.json. In the end I basically bisected the package.json until I figured out it was the repository field, and then it was trial-and-error from there.

Is it possible to add some user context directly before throwing an unimplemented error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants