Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET Core? #2

Closed
thangchung opened this issue Oct 10, 2016 · 6 comments
Closed

Support .NET Core? #2

thangchung opened this issue Oct 10, 2016 · 6 comments

Comments

@thangchung
Copy link

Hi there,
I just read the article at http://www.codeproject.com/Articles/1136943/Understanding-Retry-Pattern-with-Exponential-back using the MailMergeLib and found out this repo. This is a good lib. But my question is do you have a plan to upgrade it to .NET Core?

@axunonb
Copy link
Member

axunonb commented Oct 10, 2016

The underlying libraries all support .NET Core, so building MailMergeLib for .NET Core should be possible without too much effort. It's not on the priorities' list yet, though.

If you want to adjust the dependencies in the nuspec / project then feel free to do so. Any PR on this is highly appreciated.

@axunonb
Copy link
Member

axunonb commented Oct 14, 2016

Had a closer look today and it seems like my fist assumption was kind of very optimistic.
Need to rethink .NET Core in the future.

@axunonb axunonb closed this as completed Oct 14, 2016
@axunonb axunonb reopened this Oct 15, 2016
@axunonb axunonb removed the question label Oct 15, 2016
@axunonb
Copy link
Member

axunonb commented Oct 16, 2016

So: a first port to .NETStandard 1.6 worked as a proof of concept with the following dependencies:
"AngleSharp": "0.9.9
"MailKit": "1.8.1"
"MimeKit": "1.8.0"
"Microsoft.Extensions.Configuration.Xml": "1.0.0"
"NETStandard.Library": "1.6.0"
"System.Collections.Specialized": "4.0.1"
"System.Data.Common": "4.1.0"
"System.IO.FileSystem": "4.0.1"
"System.Runtime": "4.1.0"
"System.Threading.Thread": "4.0.0"
There were a couple of changes necessary in the code because of missing ports from .NET Framework 4.x, which were not too difficult, but still subject to some testing.
Still struggling with System.Runtime.Remoting.Messaging / CallContext.LogicalGetData() and CallContext.LogicalSetData() from SmartFormat.NET.
Any contributions still welcome.

@axunonb
Copy link
Member

axunonb commented Oct 21, 2016

@thangchung: MailMergeLib 5.1.0.0 supports .Net Core (NET Standard 1.6)

@thangchung
Copy link
Author

@axunonb Lovely. I just added your very excellent lib into my repo so that everyone can use it in their projects. Thanks so much.

@axunonb
Copy link
Member

axunonb commented Oct 23, 2016

@thangchung Thank you! I had a closer look at your repo and it contains a lot of valuable projects, quite some I was not aware of before. Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants