added check for secondaryMonitor before accessing members #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
axxapy
requested changes
Mar 16, 2022
src/modScaleThumbnails.js
Outdated
| SecondaryMonitorDisplay.prototype._getThumbnailsHeight = function(box) { | ||
| if (!this._thumbnails.visible) | ||
| return 0; | ||
| if (SecondaryMonitorDisplay) { |
There was a problem hiding this comment.
Could you please return instead of making nested code?
Suggested change
| if (SecondaryMonitorDisplay) { | |
| if (!SecondaryMonitorDisplay) return; // gnome 42: this object does not exist when there is only one monitor |
Thanks
Modified to return if SecondaryMonitorDisplay when it is not found. Removed second check (covered by function call).
axxapy
requested changes
Mar 16, 2022
| // Thumbnails on second monitor | ||
| if (!SecondaryMonitorDisplay) return; |
There was a problem hiding this comment.
Looks great!
May I also ask you to remove all other changes except for this line? (as no other changes actually change anything).
Thank you
|
Updated: removed my local revisions. |
axxapy
approved these changes
Mar 17, 2022
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue encountered in Gnome 42 where the secondary monitor was causing an issue on user login. Checking for secondary monitor prior to accessing members fixes the issue.