This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Ensure log buffer bounds #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds checks in `TagLenValue.write()` to ensure that the size of written data doesn't exceed the buffer size. Verifier in recent kernel versions requires the bound to be a constant value, so using `buf.len()` does not work. Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
vadorovsky
force-pushed
the
bounds-verifier
branch
from
c5c68fb
to
150ee79
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds checks in
TagLenValue.write()to ensure that the sizeof written data doesn't exceed the buffer size.
Verifier in recent kernel versions requires the bound to be a constant
value, so using
buf.len()does not work.Signed-off-by: Michal Rostecki vadorovsky@gmail.com