This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Fix the log buffer bounds #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change 150ee79 removed the `size > buf.len()` check, which was a mistake, because we might write to a subslice of the whole buffer, so then `buf` can be lower than `LOG_BUF_CAPACITY`. This change compares `size` with `min::(buf.len(), LOG_BUF_CAPACITY)` instead. Fixes: 150ee79 ("Ensure log buffer bounds") Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
alessandrod
approved these changes
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 150ee79 removed the
size > buf.len()check, which was amistake, because we might write to a subslice of the whole buffer, so
then
bufcan be lower thanLOG_BUF_CAPACITY.This change compares
sizewithmin::(buf.len(), LOG_BUF_CAPACITY)instead.
Fixes: 150ee79 ("Ensure log buffer bounds")
Signed-off-by: Michal Rostecki vadorovsky@gmail.com