Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow colored area to dismiss on tap #5

Closed
michinchin opened this issue Oct 11, 2019 · 5 comments
Closed

Allow colored area to dismiss on tap #5

michinchin opened this issue Oct 11, 2019 · 5 comments

Comments

@michinchin
Copy link

Hi! Love this plugin. Wanted to see if you'd be willing to add an option for dismissing the overlay by tapping on the color. On smaller screens especially, the colored region often takes up a majority of the screen and make it hard to tap out. Thanks!

@creativecreatorormaybenot
Copy link
Contributor

@axel-op and I created quite a big update to the plugin over at https://github.com/axel-op/feature_discovery. You could create a PR there and add this functionality. If you want, you can also create an issue there and then I could add this. It is a really simple adjustement as it only requires one parameter and one onTap with a condition.

@ayalma
Copy link
Owner

ayalma commented May 20, 2020

I think this issue is resolved with barrierDismissible #22
Thank's to @xsahil03x

@ayalma ayalma closed this as completed May 20, 2020
@kafein
Copy link

kafein commented May 26, 2020

@ayalma I think @michinchin asks for colored area. not outside area.
Can we reopen this? I need this feature too.
Thanks

@ayalma ayalma reopened this Jun 15, 2020
@ganeshrvel
Copy link
Contributor

i have raised a pr for the same #46

@ayalma ayalma closed this as completed Oct 8, 2020
@ayalma
Copy link
Owner

ayalma commented Oct 8, 2020

Issue resolved in 12.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants