Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer symbolic icon for volume #79

Closed
newhoa opened this issue May 11, 2022 · 1 comment
Closed

Prefer symbolic icon for volume #79

newhoa opened this issue May 11, 2022 · 1 comment

Comments

@newhoa
Copy link

newhoa commented May 11, 2022

Currently ayatana-indicator-sound prefers non-symbolic icons. So if an icon theme has audio-volume-low-symbolic in its symbolic folder and audio-volume-low in its 48/status folder, it will choose the 48px non-symbolic icon.

Panels can be light or dark and preferring a symbolic icon would be more compatible with many themes and be much clearer and more legible with any style.

Here and here look like relevant spots where this might need to be addressed. I'm not familiar with the code so I'm not sure if changing the names would be enough or if more would need to be added (like if using non-symbolic as fallbacks or limiting the maximum size).

@tari01
Copy link
Member

tari01 commented Aug 5, 2023

It is up to the theme to provide icons that control what Ayatana system indicators present to the user. These icons should always end with -panel.

For example, this is the search order for the audio-volume-low icon:

  1. audio-volume-low-panel-symbolic
  2. audio-volume-low-panel
  3. audio-volume-low
  4. audio-volume
  5. audio

The first full match will be the icon that you see (as an alternative, audio-volume-low-panel-symbolic can be a symlink to audio-volume-low-panel). I'm closing this as already implemented.

@tari01 tari01 closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants