Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of singleton SessionDataStorage #22

Open
aydenp opened this issue May 7, 2019 · 0 comments
Open

Get rid of singleton SessionDataStorage #22

aydenp opened this issue May 7, 2019 · 0 comments

Comments

@aydenp
Copy link
Owner

aydenp commented May 7, 2019

Currently, the app is very reliant on SessionDataStorage. This is a huge fault as I try to move everything to a separate framework, BankKit, as it doesn't seem right for the framework to be housing this data in a singleton. Rather, the manager should find a way to create individual sessions, which can store a Plaid item container, which will perform similarly to how SessionDataStorage does right now, except tied to a given Item. This would require a substantial rewrite.

Eventually, when we want to add multiple bank logins per app, it'll also come in handy, as it doesn't make sense to have one for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant