Fix Consumer Memory Leak: Hanging promises #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsinai
requested changes
Dec 22, 2021
src/consumer/index.js
Outdated
| @@ -319,7 +317,8 @@ module.exports = class Consumer { | |||
| ackType: options.type ? options.type : ACK_TYPES.INDIVIDUAL, | |||
| }), | |||
| }); | |||
| await process(); | |||
| process(); | |||
There was a problem hiding this comment.
Please add catch/then with logs in trace level and warn level.
Because currently we cant really tell what happened to this promise.
There was a problem hiding this comment.
Should be done now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
await process()will never be resolved due to the function calling itself again and again causing unused references to dequeued messages to stay alive, resulting in a memory leak.Made process() call asynchronous and added
returnwhen the function ends.