Consumer State Change Handling Feature #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galrose
requested changes
Jan 18, 2022
Added array of consumers for preventing unnecessary code duplication in beforeEach() function in consumer tests Added error handling for consumer state change function Added 2 basic tests for consumer state change
… since it breaks reconnection error handling)
galrose
requested changes
Jan 25, 2022
…flex into feature/consumer-state-change-handler
|
Wouldn't it be better to emit and event instead of injecting a function? |
Probably in the long run, for now this solution functions good enough. Might be a good idea to create an issue for it so it won't be forgotten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements this #81
Allow the users of this library to "listen" to change in the consumer state without needing to check at intervals.
Since this PR isn't adding anything new to the consumer's logic, but just exports some of the inners nicely, I didn't add anything tests, open for suggestions though.