protocol.py fails against btcd

[dajohi]

btcd (https://github.com/conformal/btcd) is a full node bitcoin implementation written in Go. btcd does two separate writes, one for the header and the other for the payload:

        // Write header.
        n, err := w.Write(hw.Bytes())
        if err != nil {
                totalBytes += n
                return totalBytes, err
        }
        totalBytes += n

        // Write payload.
        n, err = w.Write(payload)
        if err != nil {
                totalBytes += n
                return totalBytes, err
        }
        totalBytes += n

protocol.py fails with a short payload:
if (data_len - HEADER_LEN) < msg['length']:
self.required_len = HEADER_LEN + msg['length']
raise PayloadTooShortError("got {} of {} bytes".format(
data_len, HEADER_LEN + msg['length']))

If I add more debugging:

2014-02-28 15:02:25,683,683.5 DEBUG (connect) Payload: got 24 of 493 bytes:
msg {'checksum': '\xd4\x1d\xf7\xa2', 'length': 469, 'magic_number': '\xf9\xbe\xb4\xd9', 'command': 'inv'}

I believe you need to keep reading until there is no more data instead of erroring there.

[dajohi]

24.247.20.162:8333 is a btcd node if you want to use that for testing.

[ayeowch]

Fixed with 22f2858

btcd nodes from the latest snapshot: http://getaddr.bitnodes.io/nodes/1393635900/?q=btcd%3A