Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(migrate): migrate test tooling from chai + mocha to vitest #203

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

fazzaamiarso
Copy link
Member

test(migrate): migrate test tooling from chai + mocha to vitest

Fixes #194

Description of changes:

  • Migrate test tooling to Vitest
  • Migrate test files to typescript

Tag a reviewer: @ayoayco

Tasks:

  • I have ran the build command to make sure apps are working: npm run build
  • I have ran the tests to make sure nothing is broken: npm run test
  • I have ran the linter to make sure code is clean: npm run lint
  • I have reviewed my own code to remove changes that are not needed

@netlify
Copy link

netlify bot commented Nov 20, 2022

Deploy Preview for astro-reactive-docs failed.

Name Link
🔨 Latest commit cb81fcd
🔍 Latest deploy log https://app.netlify.com/sites/astro-reactive-docs/deploys/637a4b63654e510007208df0

@netlify
Copy link

netlify bot commented Nov 20, 2022

Deploy Preview for astro-reactive canceled.

Name Link
🔨 Latest commit cb81fcd
🔍 Latest deploy log https://app.netlify.com/sites/astro-reactive/deploys/637a4b63de945b0009c368fd

@ayoayco
Copy link
Member

ayoayco commented Nov 21, 2022

Wow this is great @fazzaamiarso let me just run through the changes. But already with pipelines passing I think this is very good!

Copy link
Member

@ayoayco ayoayco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this! Thanks so much @fazzaamiarso -- this is great progress for the project! 🚀

@ayoayco ayoayco merged commit 59d7618 into astro-reactive:main Nov 21, 2022
ayoayco pushed a commit that referenced this pull request Nov 23, 2022
* test(migrate): migrate test tooling from chai + mocha to vitest

* fix: fix wrong vitest cli command for watch
ayoayco pushed a commit that referenced this pull request Nov 23, 2022
* test(migrate): migrate test tooling from chai + mocha to vitest

* fix: fix wrong vitest cli command for watch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(library): investigate test tooling improvement
2 participants