feat: allow specifying custom color map #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejose19
force-pushed
the
ej/customColorMap
branch
from
c2e1120
to
ad83a84
Compare
|
@ayonious I just wanted to open a PR doing the same thing, are you planning to merge this in future versions? |
ayonious
requested changes
Mar 31, 2022
index.ts
Outdated
|
|
||
| export { Table, printTable, renderTable, COLOR, ALIGNMENT }; | ||
| export { Table, printTable, renderTable, COLOR, ALIGNMENT, ColorMap, DEFAULT_COLOR_MAP }; |
There was a problem hiding this comment.
ColorMap does not need to be exported here, is it?
There was a problem hiding this comment.
Maybe DEFAULT_COLOR_MAP also is not needed?
ayonious
requested changes
Mar 31, 2022
|
@ejose19 please fix the above 2 things, then I will test it out. |
|
I will add the tests later in another PR. |
ayonious
pushed a commit
that referenced
this pull request
Apr 3, 2022
|
馃帀 This PR is included in version 2.11.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憖What is this pr about?
Allow specifying a custom color map, in case the user want to use other colors other than the defaults
Added
馃懚 The naming of the PR
feat: allow specifying custom color map