Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Error struct export for asynk #61

Merged
merged 3 commits into from Aug 5, 2022

Conversation

ayrat555
Copy link
Owner

@ayrat555 ayrat555 commented Aug 5, 2022

There conflicts with blocking module's Error struct

15 | use fang::Error as FangError;
   |     ^^^^^^-----^^^^^^^^^^^^^
   |     |     |
   |     |     help: a similar name exists in the module: `error`
   |     no `Error` in the root

@ayrat555 ayrat555 requested a review from pxp9 August 5, 2022 06:44
@pxp9
Copy link
Collaborator

pxp9 commented Aug 5, 2022

Good job

Copy link
Collaborator

@pxp9 pxp9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@ayrat555 ayrat555 merged commit 2bf660c into master Aug 5, 2022
@ayrat555 ayrat555 deleted the ayrat555/fix-async-feature-imports branch August 5, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants