Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Charge Limit function unavailable for SD LCD with Board Revision 6 #170

Open
akballoon opened this issue Dec 29, 2023 · 2 comments
Open

Comments

@akballoon
Copy link

Description

On SD LCD with Board Revision 6, changing the options in Charge Limit tab (e.g. 80%) will do nothing to the actual charging limit and will cause the option to be locked at 70% as described in #165 .

Example/How to Reproduce

  1. Get a SD LCD with Board Revision 6 and supported BIOS.
  2. Install Windows.
  3. Install and Run SDT v0.7.2.
  4. Change the options in Charge Limit tab in Power Control.
  5. Observe the option being locked at 70%.
  6. Charge the device.

Possible Fix

Adding MaxBatteryCharge = true flag in new DeviceVersion() { Firmware = 0xB030, BoardID = 0x6, PDCS = 0 /* 0x2B */, BatteryTempLE = false }, under CommonHelpers\Vlv0100.cs can fix the issue and successfully limit the charge level of the battery.

屏幕截图 2023-12-29 105504

Screenshot (8)

Screenshot (9)

Additional Context

  • OS: Windows 10 22H2
  • SDT Version: Experimental build based on 0.7.2 with only modifies to Vlv0100.cs file by myself
  • BIOS Version: F7A0120
  • SD Version: LCD Version with Board Revision 6
@vajra108
Copy link

Had the same issue on Windows 11, SDT 0.7.2, not sure what's my board revision.
It's locked on 70% but it actually stopped charging when it reached 70, I just can't alter it.

@thanone2
Copy link

thanone2 commented Jun 14, 2024

Had the same issue on Windows 11, SDT 0.7.2, not sure what's my board revision. It's locked on 70% but it actually stopped charging when it reached 70, I just can't alter it.

same, but at 92% for some reason...
even with the newest version too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants