Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] do not activate debug mode by default #125

Closed
mathieucarbou opened this issue Sep 23, 2023 · 2 comments
Closed

[v3] do not activate debug mode by default #125

mathieucarbou opened this issue Sep 23, 2023 · 2 comments

Comments

@mathieucarbou
Copy link
Contributor

mathieucarbou commented Sep 23, 2023

#define UPDATE_DEBUG 1 => should be removed from the header file and not set to 1 by default. The naming could easily conflict with some other headers

#define ELEGANTOTA_DEBUG 1 => should not be set to ` by default.

I have changed to:

// #define ELEGANTOTA_DEBUG 1
// #define UPDATE_DEBUG 1

#ifdef ELEGANTOTA_DEBUG // instead of #if ELEGANTOTA_DEBUG

So that I can use in platformio:

[env:debug]
build_type = debug
build_flags = ${env.build_flags}
  -O0
  -ggdb -ggdb3 -g3
  -D DEBUG
  -D ENABLE_DEBUG
  -D ELEGANTOTA_DEBUG
  -D CORE_DEBUG_LEVEL=3
@ayushsharma82
Copy link
Owner

Instead I've wrapped them with #ifndef to set default to 0 - c08acad

@ayushsharma82
Copy link
Owner

UPDATE_DEBUG is from Update.h inside ESP core - This provides more useful data for debugging OTA procedure. Anyways, disabled them by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants