Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling #4

Open
ayyaruq opened this issue Jan 31, 2020 · 1 comment
Open

Improved error handling #4

ayyaruq opened this issue Jan 31, 2020 · 1 comment
Labels
component/sniffer enhancement New feature or request good first issue Good for newcomers

Comments

@ayyaruq
Copy link
Owner

ayyaruq commented Jan 31, 2020

We currently just kinda yolo return fmt.Errorf() or the occasional errors.New(). A proper set of error types should be used with wrapping to allow users to appropriately respond to different errors. Packet reassembly errors currently can't even be accessed, so that should be addressed too.

@ayyaruq ayyaruq added enhancement New feature or request component/sniffer labels Jan 31, 2020
@ayyaruq ayyaruq added this to the 1.0 Stable Release milestone Jan 31, 2020
@ayyaruq ayyaruq modified the milestone: 1.0 Stable Release Mar 24, 2020
@ayyaruq
Copy link
Owner Author

ayyaruq commented Jun 11, 2020

In the reassembler's run() goroutine, using something like Trace and exposing+documenting appropriate debug flags might be a useful addition. Any reassembler errors are currently built, but not logged, due to the goroutine not having any method for output. Having a global error channel is kinda gross, but may be worthwhile.

@ayyaruq ayyaruq added the good first issue Good for newcomers label Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sniffer enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant