Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all formats supported by PIL #5

Closed
wearpants opened this issue Feb 4, 2016 · 3 comments
Closed

Allow all formats supported by PIL #5

wearpants opened this issue Feb 4, 2016 · 3 comments

Comments

@wearpants
Copy link

It'd be handy to be able to generate an image in any of the formats supported by PIL. It looks as if that'd be as simple as renaming _generate_png to _generate_bytes or such, and passing the output_format argument through to PIL here: https://github.com/azaghal/pydenticon/blob/master/pydenticon/__init__.py#L247

@azaghal
Copy link
Owner

azaghal commented Jun 5, 2016

That would probably be quite a simple addition. As a curiosity, did you have a need on using generated identicons with some specific format?

Sorry for being unresponsive, been a bit busy, and this issue apparently slipped by me :)

@wearpants
Copy link
Author

I was using this in Django with factory to generate data for user profiles in tests... don't recall the exact reason why I wanted something else out of PIL. Thanks for fixing!

@azaghal
Copy link
Owner

azaghal commented Dec 3, 2016

Implemented and pushed to master branch. However, transparency is currently handled properly only for the PNG format.

@azaghal azaghal closed this as completed Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants