fix: prefix-only builtin modules are defined as external modules in s…

…ort-imports rule
azat-io · Sep 8, 2023 · 92b7240 · 92b7240
1 parent 3e11eae
commit 92b7240
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 2 deletions.
diff --git a/rules/sort-imports.ts b/rules/sort-imports.ts
@@ -201,8 +201,9 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
         tsPaths.some(pattern => minimatch(nodeElement.source.value, pattern))
 
       let isCoreModule = (value: string) =>
-        builtinModules.includes(value) ||
-        builtinModules.includes(`node:${value}`)
+        builtinModules.includes(
+          value.startsWith('node:') ? value.split('node:')[1] : value,
+        )
 
       if (node.importKind === 'type') {
         if (node.type === 'ImportDeclaration') {

diff --git a/test/sort-imports.test.ts b/test/sort-imports.test.ts
@@ -3232,5 +3232,53 @@ describe(RULE_NAME, () => {
         invalid: [],
       },
     )
+
+    ruleTester.run(
+      `${RULE_NAME}: defines prefix-only builtin modules as core node modules`,
+      rule,
+      {
+        valid: [
+          {
+            code: dedent`
+              import { writeFile } from 'node:fs/promises'
+              
+              import { useEffect } from 'react'
+            `,
+            options: [
+              {
+                groups: ['builtin', 'external'],
+              },
+            ],
+          },
+        ],
+        invalid: [
+          {
+            code: dedent`
+              import { writeFile } from 'node:fs/promises'
+              import { useEffect } from 'react'
+            `,
+            output: dedent`
+              import { writeFile } from 'node:fs/promises'
+
+              import { useEffect } from 'react'
+            `,
+            options: [
+              {
+                groups: ['builtin', 'external'],
+              },
+            ],
+            errors: [
+              {
+                messageId: 'missedSpacingBetweenImports',
+                data: {
+                  left: 'node:fs/promises',
+                  right: 'react',
+                },
+              },
+            ],
+          },
+        ],
+      },
+    )
   })
 })