Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: v2.0.0 #32

Closed
12 tasks done
azat-io opened this issue Jul 13, 2023 · 8 comments · Fixed by #39
Closed
12 tasks done

Release: v2.0.0 #32

azat-io opened this issue Jul 13, 2023 · 8 comments · Fixed by #39
Labels
enhancement New feature or request

Comments

@azat-io
Copy link
Owner

azat-io commented Jul 13, 2023

@azat-io azat-io added the enhancement New feature or request label Jul 13, 2023
@azat-io
Copy link
Owner Author

azat-io commented Jul 13, 2023

It might also be worth adding a rule for sorting MDX props.

@13OnTheCode
Copy link

May I ask what is the reason for considering the removal of read-tsconfig ?

@azat-io
Copy link
Owner Author

azat-io commented Jul 14, 2023

@13OnTheCode I don't think it's a good practice. It makes ESLint's work slow. Maybe it is better to set the value manually than to read the tsconfig.json file every time. What do you think about this?

@13OnTheCode
Copy link

@azat-io Yes, you are right. I apologize for not carefully reading the source code earlier. I mistakenly thought that reading the TSConfig configuration file served a purpose beyond retrieving compilerOptions.paths.

Deleting it is indeed a good idea because its purpose is almost identical to internal-pattern, and people usually only set ~/** or @/**.

@brightsider
Copy link

brightsider commented Aug 11, 2023

could you help me to use next version now?
I installed it by:
"eslint-plugin-perfectionist": "github:azat-io/eslint-plugin-perfectionist#next"
package-lock.json has:
"resolved": "git+ssh://git@github.com/azat-io/eslint-plugin-perfectionist.git#3210ff3b1f69702c0e4dfe7666c152828895231d",
but folder eslint-plugin-perfectionist didn't contain dist folder

also when I downloaded, builded, moved dist from next branch to installed 1.5.1, I get this error:
eslintrc.js » plugin:perfectionist/recommended-line-length: Configuration for rule "perfectionist/sort-imports" is invalid: Value {"groups":["type",["builtin","external"],"internal-type","internal",["parent-type","sibling-type","index-type"],["parent","sibling","index"],"object","unknown"],"custom-groups":{"value":{},"type":{}},"newlines-between":"always","internal-pattern":["~/**"],"read-tsconfig":false,"type":"line-length","order":"desc","ignore-case":false} should NOT have additional properties.

@azat-io
Copy link
Owner Author

azat-io commented Aug 11, 2023

We don't store dist folder in the repository. I'm planning to publish a version under the next flag early next week.

@azat-io
Copy link
Owner Author

azat-io commented Sep 4, 2023

Will be released soon.

@azat-io
Copy link
Owner Author

azat-io commented Sep 6, 2023

Released in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants