Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twinkle.diff assumes the newer revision is always on the right #107

Closed
he7d3r opened this issue May 22, 2012 · 8 comments
Closed

Twinkle.diff assumes the newer revision is always on the right #107

he7d3r opened this issue May 22, 2012 · 8 comments
Labels

Comments

@he7d3r
Copy link

he7d3r commented May 22, 2012

Although the newer revision is usually on the right, it may also be on the left. Compare the value of the code var oldid = /oldid=(.+)/.exec($('#mw-diff-ntitle1').find('strong a').first().attr("href"))[1]; on these cases:

  1. https://en.wikipedia.org/w/index.php?title=Example&diff=486460758&oldid=451042477
  2. https://en.wikipedia.org/w/index.php?title=Example&diff=451042477&oldid=486460758

In the first case, it gets the id of the most recent but on the second it gets the id of the older revision.

@QEDK
Copy link
Contributor

QEDK commented Jul 14, 2012

So, my question is how does it matter? There's no problem.

@he7d3r
Copy link
Author

he7d3r commented Jul 18, 2012

Hmm... in the current form the "oldid" matches the one which appears both in the URL and the "permanent link" in the sidebar.

@QEDK
Copy link
Contributor

QEDK commented Jul 19, 2012

Well, I prefer to get those manually.

@atlight
Copy link
Collaborator

atlight commented Oct 27, 2013

So you're saying that "current" doesn't work as expected? To be honest, no-one can really remember what the "expected" behaviors of "current/since/since mine" were supposed to be... I guess this can be considered a bug on the grounds of inconsistent behavior, though.

@helder-git: What do you think should be happening instead?

@Amalthea
Copy link
Collaborator

Amalthea commented Nov 4, 2013

Per the specification in my head the current behavior is actually correct. :)

@atlight
Copy link
Collaborator

atlight commented Nov 4, 2013

We should probably document these at WP:TW/DOC... that would help end-users to know what they do (at the moment, all they have is the tooltip), and also help us to know when they are not working as "expected"...

@atlight
Copy link
Collaborator

atlight commented Jan 4, 2016

I don't think anyone is going to ever fix this bug. I don't understand what the hell current/since/since mine are even supposed to do, and Amalthea thinks the current behaviour is OK...

@he7d3r, would you like to elaborate to help get to the bottom of this?

@he7d3r
Copy link
Author

he7d3r commented Jan 4, 2016

I guess it is working as intended then...

@he7d3r he7d3r closed this as completed Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants