New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twinkle.diff assumes the newer revision is always on the right #107
Comments
So, my question is how does it matter? There's no problem. |
Hmm... in the current form the "oldid" matches the one which appears both in the URL and the "permanent link" in the sidebar. |
Well, I prefer to get those manually. |
So you're saying that "current" doesn't work as expected? To be honest, no-one can really remember what the "expected" behaviors of "current/since/since mine" were supposed to be... I guess this can be considered a bug on the grounds of inconsistent behavior, though. @helder-git: What do you think should be happening instead? |
Per the specification in my head the current behavior is actually correct. :) |
We should probably document these at WP:TW/DOC... that would help end-users to know what they do (at the moment, all they have is the tooltip), and also help us to know when they are not working as "expected"... |
I don't think anyone is going to ever fix this bug. I don't understand what the hell current/since/since mine are even supposed to do, and Amalthea thinks the current behaviour is OK... @he7d3r, would you like to elaborate to help get to the bottom of this? |
I guess it is working as intended then... |
Although the newer revision is usually on the right, it may also be on the left. Compare the value of the code
var oldid = /oldid=(.+)/.exec($('#mw-diff-ntitle1').find('strong a').first().attr("href"))[1];
on these cases:In the first case, it gets the id of the most recent but on the second it gets the id of the older revision.
The text was updated successfully, but these errors were encountered: