New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI reporting doesn't check to see if the date header already exists #54

atlight opened this Issue Aug 7, 2011 · 2 comments


None yet
1 participant

atlight commented Aug 7, 2011

From WT:TW:
Twinkle does not add on to the original Sock report, even if it's on the same day. --Σ 06:13, 30 July 2011 (UTC)


This comment has been minimized.


atlight commented Jul 9, 2012

From Sigma's talk page:

I came across this Twinkle issue, and was wondering whether this is actually worth fixing. I imagine you wanted Twinkle to "merge" multiple SPI reports made on the one day. However, this would be quite difficult to code into Twinkle, and in circumstances where someone else made the other report earlier in the day, it would be confusing to have two reports from different users merged into one. What do you think? — This, that, and the other (talk) 11:57, 8 July 2012 (UTC)

Well, I see a SPI report with several features.

  • Date in the level 2 heading
  • List of suspected socks, with link to the user compare report
  • Signature of a user, which should be right above the "Comments by other users" section
  • Content below, before the next level 2 heading or the end of the page

I too believe that this might be difficult to implement. But merging two reports from different users into one could be avoided by checking if the signature of the earlier report contains your username. →Στc. 05:20, 9 July 2012 (UTC)


This comment has been minimized.


atlight commented Dec 24, 2012

That issue is by design when I redid the SPI report function. Merging new reports into old ones is difficult to implement, creates a lot more format dependency in the code, causes all sorts of problems with case status tracking (e.g., merging into a closed case? a case where CU has been endorsed? a case where a check has been run already?), and is very rarely useful. T. Canens (talk) 01:46, 24 December 2012 (UTC)

Won't fix.

@atlight atlight closed this Dec 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment