Bump font size to 12px #1034
Bump font size to 12px #1034
Conversation
| @@ -40,6 +40,7 @@ form.quickform | |||
| form.quickform * | |||
| { | |||
| font-family: sans-serif; | |||
| font-size: 12px; | |||
There was a problem hiding this comment.
Why this and not removing font-size from .ui-dialog.morebits-dialog .morebits-dialog-content? https://github.com/azatoth/twinkle/blob/07fffdf04bf8adf008862eb2ac2e5cc52c28b9d9/morebits.css#L224
There was a problem hiding this comment.
I was thinking of this more as a proposal so wasn't paying attention to the code. Let's see. Good old days of playing with the CSS...
|
Somewhat related, but I've been meaning on looking in on bumping some things up in size after looking at some of it for the jquery tooltip menus and earlier cleanup. Warranted IMO. |
| body.skin-monobook .morebits-dialog { | ||
| font-size: 125%; | ||
| } |
There was a problem hiding this comment.
This (at 0,2,1) was being over-ridden by the more specific .ui-dialog.morebits-dialog .morebits-dialog-content selector (0,3,0) so this wasn't doing anything at all.
There was a problem hiding this comment.
Well, it was doing something. I get 11.44px with, 11px without. More generally, shifts things around a bit. Continued below...
|
Should we use percentages instead of pixels? It looks like 100% is 13px, so for 12px we'll need around 92.3%. |
|
So, as far as relevant items, we've got (top to bottom):
I haven't been able to do much testing today, but |
A thorough version of wikimedia-gadgets#1034. Fixes the issue of font size not being scaled for users with uncommon browser font settings. Also makes the sizes consistent across all skins. The px translation of the % sizes used are: (on the default browser settings) - 12px in most places - 12.96px (108% of 12px) for the titlebar and h5 headers - 11.64px (97% of 12px) for footer links On timeless, the sizes are very slightly different (12.008px instead of 12px, etc). This PR touches only morebits.css. Left for the future: - select2 css tweaks invloves a hardcoded 13px, which won't scale with browser font settings - The large text option in TWPREFS also uses an absolute 13px This is live on testwiki.
Twinkle has been using a font-size of 11.44px (11px on monobook) on all UI dialog texts all these years. I think this is way too small that it causes accessibility issues for at least some users and is generally hard to read.
I propose bumping the morebits font-size to 12px. This change is subtle enough that it doesn't disturb the relative positioning of any UI elements, and would likely go unnoticed, but at the same time it does make things easier to read.