xfd/prod: show Find sources links in AfD and PROD windows #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amorymeltzer
added
Feature request
Module: prod
Module: twinkle
The code doesn't look particularly nice, but this should be actually useful in practise. Closes wikimedia-gadgets#1047.
Amorymeltzer
force-pushed
the
findsources
branch
from
362372d
to
3d271c1
Compare
Amorymeltzer
approved these changes
Sep 5, 2020
There was a problem hiding this comment.
Rebased. LGTM, although, yes, agreed on the code! I do think it's worth discussing preview rendering but that need not stop this in any meantime! 👏
| }; | ||
| var title = encodeURIComponent(Morebits.pageNameNorm); | ||
| return $('<div>') | ||
| .addClass('plainlinks') |
There was a problem hiding this comment.
You're just replicating the template, so shouldn't be changed, but I don't think the Twinkle render generates the external links that make this necessary.
(I personally really feel like the template should retain the external link styling since they are external links...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code doesn't look particularly nice, but this should be useful in practice.
Closes #1047.