protect: Add options for watching protected/requested/tagged pages #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amorymeltzer
added
Feature request
Module: config
Module: protect
Module: twinkle
|
|
Amorymeltzer
force-pushed
the
protect-watchpage
branch
from
6b1b2d8
to
0eba96d
Compare
Amorymeltzer
force-pushed
the
protect-watchpage
branch
from
0eba96d
to
43e12a2
Compare
`watchRequestedPages`, `watchPPTaggedPages`, and `watchProtectedPages`
Amorymeltzer
force-pushed
the
protect-watchpage
branch
from
43e12a2
to
ab40caa
Compare
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Dec 13, 2020
PR wikimedia-gadgets#1133 was merged without fully accounting for the fact that providing a watchlist expiry would overwrite indefinite watching, which is nonideal; see wikimedia-gadgets#1230. Like wikimedia-gadgets#1230, this is imperfect, as it only provides a boolean for watched or not, and doesn't give any information on an expiry. We can at least rely on the information being available, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
watchRequestedPages,watchPPTaggedPages, andwatchProtectedPagesAs written, dependent on #1090; it need not be.