Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arv: Note and soften message if user is already blocked #1204

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

Amorymeltzer
Copy link
Collaborator

@Amorymeltzer Amorymeltzer commented Nov 22, 2020

Not done in #1184 since I was trying for fidelity to the original, but I think the combination of tweaked language + black versus red text makes it palatable; cf the changes to markblocked I made for partial blocks.

cc @DannyS712 @creffett

@Amorymeltzer Amorymeltzer changed the title arv: Note and soften message is user already blocked arv: Note and soften message if user is already blocked Nov 22, 2020
@Amorymeltzer Amorymeltzer added this to the December 2020 update milestone Dec 7, 2020
@Amorymeltzer Amorymeltzer merged commit 0bff311 into wikimedia-gadgets:master Dec 12, 2020
@Amorymeltzer Amorymeltzer deleted the arv-partialnote branch December 12, 2020 01:28
Amorymeltzer added a commit to Amorymeltzer/twinkle that referenced this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant