TfD: don't enter a newline after the TfD template #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be happier just not inserting a newline at all. |
|
done |
|
I'll merge this when you submit only a single commit with a nice commit message :) At the moment there are two commits on top of one another. Thanks for noticing this and taking the time to submit a pull request. |
Newlines are significant and may break the functioning of the template
martijnhoekstra
force-pushed
the
TfDwhitespace
branch
from
999c470
to
1f088e9
Compare
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Mar 7, 2019
Lack of a newline (wikimedia-gadgets#254) causes issues if the template is a table. Closes wikimedia-gadgets#359.
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Mar 8, 2019
Lack of a newline (wikimedia-gadgets#254) can cause issues if the template is a table or uses other wikitext formatting (e.g. indentation). As [discussed at TW:TW](https://en.wikipedia.org/w/index.php?oldid=886765882#Twinkle_TFDs_breaking_tables), this should (mostly?) only be relevant if the standard or sidebar options are appropriate; the two inline templates should clearly never have a newline. Closes wikimedia-gadgets#359.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newlines are significant and may break the functioning of the template