Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfd: Notify creator of second template of tfm nomination #256

Merged

Conversation

martijnhoekstra
Copy link
Contributor

This is hotly requested by TfD regulars, even if it is non-standard for other XfDs

@martijnhoekstra
Copy link
Contributor Author

@atlight does this settle all issues? Can I squash these?

@atlight
Copy link
Collaborator

atlight commented Feb 25, 2015

Yes, looks fine, although I haven't tested it. Please squash them into a single commit; that is a definite prerequisite to merging any pull request.

this is hotly requested by TfD regulars, even if it is non-standard for
other XfDs
@atlight
Copy link
Collaborator

atlight commented Jun 9, 2015

Ooh, seems like I forgot about this. Would you still like this to be merged? Have you tested it?

@martijnhoekstra
Copy link
Contributor Author

Yes, I've tested it. It's been ages since I've done anything on Wikipedia though, so I'm not sure if it still functions as intended.

@Amorymeltzer Amorymeltzer changed the title notification of creator of second template of merge xfd: Notify creator of second template of tfm nomination Jan 18, 2019
@Amorymeltzer Amorymeltzer merged commit a49353e into wikimedia-gadgets:master Jan 18, 2019
@martijnhoekstra
Copy link
Contributor Author

martijnhoekstra commented Jan 18, 2019

Thanks for merging this @Amorymeltzer !

Did you check if it still works properly? It's four years old by now, so between the time I wrote it and now, things may have broken.

@Amorymeltzer
Copy link
Collaborator

I did and was pleasantly surprised! It helps that none of that code had changed for at least five years. I think this just got missed, sorry about that. I'm not a TfM regular but I imagine they'll appreciate it.

@martijnhoekstra
Copy link
Contributor Author

martijnhoekstra commented Jan 18, 2019 via email

@Amorymeltzer
Copy link
Collaborator

Just wanted to say, saw this in the wild today, very cool!

@martijnhoekstra
Copy link
Contributor Author

martijnhoekstra commented Feb 15, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants