New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xfd: Notify creator of second template of tfm nomination #256
xfd: Notify creator of second template of tfm nomination #256
Conversation
@atlight does this settle all issues? Can I squash these? |
Yes, looks fine, although I haven't tested it. Please squash them into a single commit; that is a definite prerequisite to merging any pull request. |
this is hotly requested by TfD regulars, even if it is non-standard for other XfDs
ff448fe
to
fc400a8
Compare
Ooh, seems like I forgot about this. Would you still like this to be merged? Have you tested it? |
Yes, I've tested it. It's been ages since I've done anything on Wikipedia though, so I'm not sure if it still functions as intended. |
Thanks for merging this @Amorymeltzer ! Did you check if it still works properly? It's four years old by now, so between the time I wrote it and now, things may have broken. |
I did and was pleasantly surprised! It helps that none of that code had changed for at least five years. I think this just got missed, sorry about that. I'm not a TfM regular but I imagine they'll appreciate it. |
Ah, good to hear. I wasnt even sure if the process is still the same!
…On Fri, Jan 18, 2019, 18:40 Amory Meltzer ***@***.*** wrote:
I did and was pleasantly surprised! It helps that none of that code
<https://github.com/azatoth/twinkle/blame/10de46eea89c2a27ae3a13d9a63f189e9da33687/modules/twinklexfd.js#L1543-L1557>
had changed for at least five years. I think this just got missed, sorry
about that. I'm not a TfM regular but I imagine they'll appreciate it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#256 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA13ET7xB3UBnP8Bez7_DYgLP0xB-nJ0ks5vEgcqgaJpZM4DjxzX>
.
|
Just wanted to say, saw this in the wild today, very cool! |
Great to hear, I'm happy it's finding good use.
…On Fri, Feb 15, 2019, 17:13 Amory Meltzer ***@***.*** wrote:
Just wanted to say, saw this in the wild today, very cool!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#256 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA13EUuemxt0ud0byMGcUct2KA1JRfLSks5vNtywgaJpZM4DjxzX>
.
|
This is hotly requested by TfD regulars, even if it is non-standard for other XfDs