Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update {{uw-spam1}} label and edit summary #390

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Update {{uw-spam1}} label and edit summary #390

merged 1 commit into from
Mar 14, 2018

Conversation

JJMC89
Copy link
Contributor

@JJMC89 JJMC89 commented Aug 18, 2017

"spam links" → "inappropriate external links"
Requested at Wikipedia talk:Twinkle#Edit summary for uw-spam1

"spam links" → "inappropriate external links"
@rchard2scout
Copy link

It looks like the edit summaries have been pulled from WP:UTM, so maybe it should be changed there as well?

@MusikAnimal
Copy link
Collaborator

What about uw-spam2, 3, 4, 4im?

I otherwise see nothing wrong with this change, and yes I would update WP:UTM, too.

@JJMC89
Copy link
Contributor Author

JJMC89 commented Mar 14, 2018

@MusikAnimal: uw-spam1 doesn't mention spam, only that the links are inappropriate. The rest of the series does. WP:UTM only has the one line for the series, so an single one cannot be changed there.

@kevinji
Copy link
Collaborator

kevinji commented Mar 14, 2018

Seems reasonable to me.

@kevinji kevinji merged commit 3da2627 into wikimedia-gadgets:master Mar 14, 2018
@JJMC89 JJMC89 deleted the uw-spam1 branch March 14, 2018 00:53
Siddhartha-Ghai pushed a commit to Siddhartha-Ghai/twinkle that referenced this pull request Jan 2, 2019
"spam links" → "inappropriate external links"

(cherry picked from commit 3da2627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants