Move "TW" to left of read article button #393
Conversation
|
This move will significantly get ride of the jumping around of buttons. Looks good. |
|
This is a big change. We're not just moving a tab to the left of Read (like you did with Rater), but a dropdown menu -- while leaving other dropdown menus on the right. As a frontend guy this makes me cringe. I still think there's a better way to do this. After all, this patch only helps some people. If you use MoreMenu, for instance, the extra dropdowns will still be jumping things around. Should we move those to the left, too? (Seriously?) I'd argue for consistency. Is there a change we could make to MW core that would help in the long run? At any rate, I think this is probably deserving of broader input. Did we make any sort of "See this discussion" notifications on WP:VPT, WP:VPR, etc.? Input from more than 4 people would be ideal, given the gadget affects tens of thousands |
|
What I've often thought about doing was to allocate space for the dropdown from Twinkle's CSS, by clever margin or ::after trickery - isn't CSS frontloaded, so there should be no delay? |
Yes, that was the thought with #336. I think it's doable, but you'd need some JS to remove the CSS placeholder if you're on a page where Twinkle isn't shown. So if you are on a Special page you'd still get some jumpiness, but it would seem that users spent most of their time on non-Special pages, so maybe this is OK. |
|
Or we could use CSS selectors to skip these pages - don't forget the page name is a class on the |
|
I personally just want this major problem to be fixed. It slows me and many
other editors down especially when I am on a slow internet connection. The
proposal has been up for a week.
James
…On Fri, Sep 8, 2017 at 9:15 AM, MusikAnimal ***@***.***> wrote:
What I've often thought about doing was to allocate space for the dropdown
from Twinkle's CSS, by clever margin or ::after trickery - isn't CSS
frontloaded, so there should be no delay?
Yes, that was the thought with #336
<#336>. I think it's doable, but
you'd need some JS to *remove* the CSS placeholder if you're on a page
where Twinkle isn't shown. So if you are on a Special page you'd still get
some jumpiness, but it would seem that users spent most of their time on
non-Special pages, so maybe this is OK.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#393 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUFsy4RiNH_kgnv7gTs-eaiNUPp0QiRoks5sgVoWgaJpZM4PRHkv>
.
--
James Heilman
MD, CCFP-EM, Wikipedian
The Wikipedia Open Textbook of Medicine
|
|
We need a policy that all gadgets are not to cause "jumping issues". As TW
is used by so many people it is thus so important to fix.
Is there seriously anyone who wants to "keep" the jumping issue because
they like it when buttons jump around? By the way there was also discussion
on Wikimedia-l
James
…On Fri, Sep 8, 2017 at 9:19 AM, James Heilman ***@***.***> wrote:
I personally just want this major problem to be fixed. It slows me and
many other editors down especially when I am on a slow internet connection.
The proposal has been up for a week.
James
On Fri, Sep 8, 2017 at 9:15 AM, MusikAnimal ***@***.***>
wrote:
> What I've often thought about doing was to allocate space for the
> dropdown from Twinkle's CSS, by clever margin or ::after trickery - isn't
> CSS frontloaded, so there should be no delay?
>
> Yes, that was the thought with #336
> <#336>. I think it's doable,
> but you'd need some JS to *remove* the CSS placeholder if you're on a
> page where Twinkle isn't shown. So if you are on a Special page you'd still
> get some jumpiness, but it would seem that users spent most of their time
> on non-Special pages, so maybe this is OK.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#393 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AUFsy4RiNH_kgnv7gTs-eaiNUPp0QiRoks5sgVoWgaJpZM4PRHkv>
> .
>
--
James Heilman
MD, CCFP-EM, Wikipedian
The Wikipedia Open Textbook of Medicine
--
James Heilman
MD, CCFP-EM, Wikipedian
The Wikipedia Open Textbook of Medicine
|
Nice :) I think we should give this a try! I don't want to be left with some dropdowns on the left, some on the right.
I agree, it's certainly a problem that's driving everyone nuts. The CSS solution seems more ideal, as we'd position things the way they are now, except make it so it doesn't jump. I'm going to comment on the discussion and let everyone know there may be a better option. I guess don't worry about making a post at VPT and VPR just yet. |
|
Okay if CSS changes fix the problem than I am happy. How long to role this
out you think?
J
…On Fri, Sep 8, 2017 at 9:23 AM, MusikAnimal ***@***.***> wrote:
Or we could use CSS selectors to skip these pages - don't forget the page
name is a class on the element.
Nice :) I think we should give this a try! I don't want to be left with
some dropdowns on the left, some on the right.
I personally just want this major problem to be fixed. It slows me and many
other editors down especially when I am on a slow internet connection. The
proposal has been up for a week.
I agree, it's certainly a problem that's driving everyone nuts. The CSS
solution seems more ideal, as we'd position things the way they are now,
except make it so it doesn't jump. I'm going to comment on the discussion
and let everyone know there may be a better option. I guess don't worry
about making a post at VPT and VPR just yet.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#393 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUFsyxpMTK7J9hnIiKzLWKXCzqnaOPoxks5sgVvtgaJpZM4PRHkv>
.
--
James Heilman
MD, CCFP-EM, Wikipedian
The Wikipedia Open Textbook of Medicine
|
I'm fiddling around on testwiki right now. |
|
Declining in favour of #336. Thanks for the help, nonetheless! |
See https://en.wikipedia.org/wiki/Wikipedia_talk:Twinkle#Button_load_issues