New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "TW" to left of read article button #393

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@WikiDocJames

This comment has been minimized.

WikiDocJames commented Sep 8, 2017

This move will significantly get ride of the jumping around of buttons. Looks good.

@MusikAnimal

This comment has been minimized.

Collaborator

MusikAnimal commented Sep 8, 2017

This is a big change. We're not just moving a tab to the left of Read (like you did with Rater), but a dropdown menu -- while leaving other dropdown menus on the right. As a frontend guy this makes me cringe. I still think there's a better way to do this. After all, this patch only helps some people. If you use MoreMenu, for instance, the extra dropdowns will still be jumping things around. Should we move those to the left, too? (Seriously?) I'd argue for consistency. Is there a change we could make to MW core that would help in the long run?

At any rate, I think this is probably deserving of broader input. Did we make any sort of "See this discussion" notifications on WP:VPT, WP:VPR, etc.? Input from more than 4 people would be ideal, given the gadget affects tens of thousands

@atlight

This comment has been minimized.

Collaborator

atlight commented Sep 8, 2017

What I've often thought about doing was to allocate space for the dropdown from Twinkle's CSS, by clever margin or ::after trickery - isn't CSS frontloaded, so there should be no delay?

@MusikAnimal

This comment has been minimized.

Collaborator

MusikAnimal commented Sep 8, 2017

What I've often thought about doing was to allocate space for the dropdown from Twinkle's CSS, by clever margin or ::after trickery - isn't CSS frontloaded, so there should be no delay?

Yes, that was the thought with #336. I think it's doable, but you'd need some JS to remove the CSS placeholder if you're on a page where Twinkle isn't shown. So if you are on a Special page you'd still get some jumpiness, but it would seem that users spent most of their time on non-Special pages, so maybe this is OK.

@atlight

This comment has been minimized.

Collaborator

atlight commented Sep 8, 2017

Or we could use CSS selectors to skip these pages - don't forget the page name is a class on the <body> element.

@WikiDocJames

This comment has been minimized.

WikiDocJames commented Sep 8, 2017

@WikiDocJames

This comment has been minimized.

WikiDocJames commented Sep 8, 2017

@MusikAnimal

This comment has been minimized.

Collaborator

MusikAnimal commented Sep 8, 2017

Or we could use CSS selectors to skip these pages - don't forget the page name is a class on the element.

Nice :) I think we should give this a try! I don't want to be left with some dropdowns on the left, some on the right.

I personally just want this major problem to be fixed. It slows me and many
other editors down especially when I am on a slow internet connection. The
proposal has been up for a week.

I agree, it's certainly a problem that's driving everyone nuts. The CSS solution seems more ideal, as we'd position things the way they are now, except make it so it doesn't jump. I'm going to comment on the discussion and let everyone know there may be a better option. I guess don't worry about making a post at VPT and VPR just yet.

@WikiDocJames

This comment has been minimized.

WikiDocJames commented Sep 8, 2017

@MusikAnimal

This comment has been minimized.

Collaborator

MusikAnimal commented Sep 8, 2017

How long to role this out you think?

I'm fiddling around on testwiki right now.

@MusikAnimal

This comment has been minimized.

Collaborator

MusikAnimal commented Sep 12, 2017

Declining in favour of #336. Thanks for the help, nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment