Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prod: add alert if BLPPROD is applied but article is not in Category:Living people #458

Merged
merged 1 commit into from Dec 11, 2018

Conversation

siddharthvp
Copy link
Member

If page is being nominated for BLPPROD, a check is done to see if article has [[Category:Living people]]. If not, user is warned about it and they can choose to either continue or abort the action. If they choose to continue, [[Category:Living people]] is added to the article along with the prod tag.

This feature makes TW smarter and helps prevent bios of deceased people (and non-bios) from being mistakenly tagged for blp-prod.

@Amorymeltzer
Copy link
Collaborator

So, BLP is a little misleading, as the policy includes the recently dead while Category:Living people includes only the living. It might be unlikely, but BLPPROD could well apply to a page not in CAT:LP. I think it's probably okay to offer an alert in that case, but I don't think automatically adding CAT:LP is a good idea in that case. Perhaps reword the The category will be added... comment to suggest the user add it if they do indeed proceed?

@siddharthvp
Copy link
Member Author

The BLP policy includes the recently dead as well as biographical details covered in other articles that are not bios. But the policy on BLPPROD does not make any mention of recently dead people.

Although policy on biographies of living persons covers all types of biographical material, the use of this deletion procedure applies only to articles that are biographies of living people.

So I don't think there's a problem here.

@Amorymeltzer
Copy link
Collaborator

I checked with another sysop, who reads that as I do: in direct reference to the policy rather than the vernacular meaning. The lines after it give some context as to what BLPPROD wouldn't cover.

@siddharthvp
Copy link
Member Author

@Amorymeltzer ok, reluctantly removed my precious category-adding code :)

@Amorymeltzer Amorymeltzer self-assigned this Dec 11, 2018
modules/twinkleprod.js Outdated Show resolved Hide resolved
modules/twinkleprod.js Outdated Show resolved Hide resolved
modules/twinkleprod.js Outdated Show resolved Hide resolved
modules/twinkleprod.js Outdated Show resolved Hide resolved
@Amorymeltzer Amorymeltzer changed the title add alert if BLPPROD is applied but article is not in Category:Living people prod: add alert if BLPPROD is applied but article is not in Category:Living people Dec 11, 2018
Copy link
Collaborator

@Amorymeltzer Amorymeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor grammar/stylistic changes

@Amorymeltzer
Copy link
Collaborator

It was nice code!

@siddharthvp
Copy link
Member Author

All grammar/stylistic changes implemented and resulting commits squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants