morebits: overhaul action complete status messages #646
Conversation
The action complete status messages (the last line of status) in almost all Twinkle modules do not read correctly. Such as in Tag module, it says "Tagging complete: completed". In xfd, it says "Nomination complete, redirecting to discussion page: completed". None of the Twinkle modules make meaningful use of Morebits.wiki. actionCompleted.postfix (the part of the status message after the colon), allowing it to remain "completed" which is the default. There is no way to suppress the display of the colon and postfix. This commit introduces a new function that creates a status line without a colon separator, and uses it for the action-completed message instead of using a normal Morebits.status object. This does away with Morebits.wiki.actionCompleted.postfix, which as described above, has no utility. The default value of Morebits.wiki.actionCompleted.notice is changed from "Action", which does not make much sense, to null. If it is not redefined in the module, the entire action-complete message is suppressed. This was not possible earlier, and was being achieved in RPP/PP through an ugly hack.
|
Okay, wrapping my head around this. Your summary was good, but it took me a bit to translate it to the code. I'm not sure why I thought this was more involved? A brief summary:
Sounds good to me! What happens to anything else out there? It would just whatever was in
Could remove in, say, 3-6 months? Might be a little much for such a little thing. |
They would just show whatever is there in Morebits.wiki.actionCompleted.notice - which in all external user scripts is something along the lines of "... completed, reloading page in a second". So this is in fact ideal. User:Bellezzasolo/Scripts/arb.js, for instance, displays the following action complete msg now: this would become
I have taken care of the 3 modules that were using postfix. So it now is not present anywhere. Of the 8 search results for userspace scripts, 1 is a functional script by me that I'll fix, remaining 7 are unused and outdated copies of twinkle code. The many things using |
This is basically the number I was looking for, places where information would be made worse. Looks like nothing on enwiki will be borked by removing AFAICT only zh-yue directly imports |
|
Merged in 9cef0d4 |
(See #645, which adds docs for Morebits.status, if you're unfamiliar with the really convoluted Morebits.status system.)
The action complete status messages (the last line of status) in almost all Twinkle modules do not read correctly. Such as in Tag module, it says "Tagging complete: completed". In xfd, it says "Nomination complete, redirecting to discussion page: completed". None of the Twinkle modules make meaningful use of
Morebits.wiki.actionCompleted.postfix(the part of the status message after the colon), allowing it to remain "completed" which is the default. There is no way to suppress the display of the colon and postfix.This commit introduces a new function that creates a status line without a colon separator, and uses it for the action-completed message instead of using a normal Morebits.status object. This does away with
Morebits.wiki.actionCompleted.postfix, which as described above, has no utility.The default value of
Morebits.wiki.actionCompleted.noticeis changed fromAction, which does not make much sense, tonull. If it is not redefined in the module, the entire action-complete message is suppressed. This was not possible earlier, and was being achieved in RPP/PP through an ugly hack.