Convert mw.RegExp.escape to mw.util.escapeRegExp as the former is being deprecated #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng deprecated See [T218339](https://phabricator.wikimedia.org/T218339); `mw.RegExp` has been deprecated and will be removed in MW-1.35, as the `escape` function was the only item in it (itself from a prior module). The same function (different name) has since 2015 been already present in `mw.util`. Co-authored-by: Siddharth VP <siddharthvp@gmail.com> Co-authored-by: Amory Meltzer <Amorymeltzer@gmail.com>
Amorymeltzer
added
Module: morebits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See T218339;
mw.RegExphas been deprecated and will be removed in MW-1.35, as theescapefunction was the only item in it (itself from a prior module). The same function (different name) has since 2015 been already present inmw.util.Tidied up from #708, cc @siddharthvp