Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morebits: Use custom message for spamblacklist #722

Merged

Conversation

Amorymeltzer
Copy link
Collaborator

Restores custom message removed in #707. Custom messages as specified in MediaWiki:Spamprotectiontext and MediaWiki:Spamprotectionmatch get inserted into the response, which can lead to absurdly lengthy wikitext messages in Twinkle (see #707 (comment)).

Restores custom message removed in wikimedia-gadgets#707.  Custom messages as specified in MediaWiki:Spamprotectiontext and MediaWiki:Spamprotectionmatch get inserted into the response, which can lead to absurdly lengthy wikitext messages in Twinkle (see wikimedia-gadgets#707 (comment)).
@Amorymeltzer Amorymeltzer added the Module: morebits The morebits.js library label Oct 7, 2019
@Amorymeltzer
Copy link
Collaborator Author

Thanks for reporting this, @siddharthvp

@Amorymeltzer
Copy link
Collaborator Author

Live on testwiki in case anyone wants to test, but it seems to get me the response I want, so I'll push to enwiki in ~hour or so if no issues.

@siddharthvp
Copy link
Member

This is the message I see currently on testwiki:
Screenshot (10) png

Seems completely different from what you wrote. Didn't try investigating why, through.

@Amorymeltzer
Copy link
Collaborator Author

@siddharthvp Did you use revert or something else from fluff? This PR just tackles morebits, I believe what you're noticing is due to what you and I were talking about in #707, namely that since fluff uses Morebits.wiki.api and not Morebits.wiki.page nor does it provide an onError fallback, we end up with this.

We can either duplicate the morebits stuff in an additional fluff callback (quicker, worse) or convert to Morebits.wiki.page (better).

@siddharthvp
Copy link
Member

siddharthvp commented Oct 7, 2019

I used CSD, specifically tried to nominate the page for G12 deletion specifying copyvio source as a spamblacklisted url.

@Amorymeltzer
Copy link
Collaborator Author

Try again? Works just fine for me, same thing.

@siddharthvp
Copy link
Member

This time, tried to PROD the page with reason http://areallyevilsite.com . Same result:
Screenshot (11) png

Also tried after clearing browser caches and cookies. Anyway, I guess this error text is also fine howsoever it is coming :)

But another bug is revealed here as you can see: placing of {{old prod}} succeeded w/o the prod being added :(

@Amorymeltzer
Copy link
Collaborator Author

Amorymeltzer commented Oct 7, 2019 via email

@Amorymeltzer Amorymeltzer added this to the November 2019 update milestone Oct 15, 2019
@Amorymeltzer Amorymeltzer merged commit 4582fae into wikimedia-gadgets:master Oct 25, 2019
@Amorymeltzer Amorymeltzer deleted the morebits-customsblwarning branch October 25, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: morebits The morebits.js library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants