tag: Fix bug in redirect tag matching #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some redirect tags (e.g. {{R from alternative language}}) can take parameters (e.g. "|from=de|to=fr"), which would cause the regex to fail to match the entire pagetext. Specifically, in:
(?:[^|{}]*|{{[^}]*}})+
the
{{[^}]*}}
portion matches individual redirect templates, and removing the pipe from [^|}] allows the content of that template to contain parameters.
Previously, the tag module would just fail, and the regex might just insert new tags in the middle of already-existing templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some redirect tags (e.g. {{R from alternative language}}) can take parameters (e.g. "|from=de|to=fr"), which would cause the regex to fail to match the entire pagetext. Specifically, in:
(?:[^|{}]|{{[^}]}})+
the
{{[^}]*}}
portion matches individual redirect templates, and removing the pipe from [^|}] allows the content of that template to contain parameters.
Previously, the tag module would just fail, and the regex might just insert new tags in the middle of already-existing templates.
Not sure what the case theoretically was where not excluding a pipe here would cause an issue.