tag: fix bug when there are no available tags #732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are no available tags (all are already present or none provided) the module would die when trying to untag (like a printer low on cyan). This is incredibly unlikely on enwiki, but I can theoretically imagine other wikis with fewer maintenance templates might run into an issue where all available templates are already transcluded. Reported on my testwiki talk.
I spent some time delving into other tightenings when the various tag objects were empty or emptied, but it's only partially doable without some major restructuring, and I'm not sure it's even a good idea.