xfd: Fix bug in notification checkbox when changing modes #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Amorymeltzer
force-pushed
the
xfd-fixnotifytoggle
branch
from
6701ec4
to
02dcbf4
Compare
Added in 9d6818a along with CfD/S, presumably intended to allow the user to return to their previous state after "visiting" CfD/S. Current behavior: Changing modes (e.g. AfD->TfD) resets the state of the "Notify page creator" checkbox, so that after loading a new XfD venue, it is always checked, unless switching to CfD/S, where the box is unchecked (and disabled). If switching *away* from CfD/S, the default state of the checkbox will be set to whatever the checkbox was before moving to CfD/S; that is, if the checkbox was *unchecked* in AfD mode, then the user switched to CfD/S, every subsequent switch would uncheck the box, until of course they return CfD/S. This commit: Does away with the whole damn thing, just sets the box unchecked (and disabled) for CfD/S and RM, and checked for everybody else.
Amorymeltzer
force-pushed
the
xfd-fixnotifytoggle
branch
from
02dcbf4
to
4385976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in 9d6818a along with CfD/S, presumably intended to allow the user to return to their previous state after "visiting" CfD/S.
Current behavior: Changing modes (e.g. AfD->TfD) resets the state of the "Notify page creator" checkbox, so that after loading a new XfD venue, it is always checked, unless switching to CfD/S, where the box is unchecked (and disabled). If switching away from CfD/S, the default state of the checkbox will be set to whatever the checkbox was before moving to CfD/S; that is, if the checkbox was unchecked in AfD mode, then the user switched to CfD/S, every subsequent switch would uncheck the box, until of course they return CfD/S.
This commit: Does away with the whole damn thing, just sets the box unchecked (and disabled) for CfD/S and RM, and checked for everybody else.