Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twinkle.js: Add Special:Block to whitelisted special pages #743

Merged
merged 1 commit into from Nov 17, 2019

Conversation

Amorymeltzer
Copy link
Collaborator

@Amorymeltzer Amorymeltzer commented Oct 31, 2019

Allows users to use Twinkle modules there if desired. As of now, it loads: arv, warn, welcome, and talkback, as well as block if the user is a sysop.

Also updated/unified headers describing where some modules that use wgRelevantUserName that weren't changed (#208).


IMO this solves the concern expressed in #699.

@Amorymeltzer Amorymeltzer added this to the November 2019 update milestone Oct 31, 2019
@Amorymeltzer Amorymeltzer added Feature request Module: twinkle The twinkle.js global gadget file labels Oct 31, 2019
@Amorymeltzer
Copy link
Collaborator Author

Amorymeltzer commented Oct 31, 2019

I'd've bet good money this morning that this was already the case...

@siddharthvp
Copy link
Member

You'll have to update twinkle-pagestyles.css as well.

Allows users to use Twinkle modules there if desired.  As of now, it loads: arv, warn, welcome, and talkback, as well as block if the user is a sysop.

Also updated/unified headers describing where some modules that use `wgRelevantUserName` that weren't changed (wikimedia-gadgets#208).
@Amorymeltzer
Copy link
Collaborator Author

Good catch, thanks!

@Amorymeltzer Amorymeltzer merged commit 4a9a544 into wikimedia-gadgets:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Module: twinkle The twinkle.js global gadget file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants