Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twinkle/morebits/config: remove antique IE 9 stuff #756

Merged
merged 1 commit into from Nov 30, 2019

Conversation

siddharthvp
Copy link
Member

JavaScript no longer loads in MediaWiki in IE <11, so there's no point in keeping old IE version checks or special cases.

JavaScript no longer loads in MediaWiki in IE <11, so there's no point in keeping old IE version checks or special cases.
@Amorymeltzer Amorymeltzer added Module: config Module: twinkle The twinkle.js global gadget file labels Nov 25, 2019
@Amorymeltzer Amorymeltzer added this to the January 2020 update milestone Nov 25, 2019
Copy link
Collaborator

@Amorymeltzer Amorymeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This all checks out — untested but LGTM 👍

@Amorymeltzer
Copy link
Collaborator

Rather than amending the commit message:
*JS disabled for IE 10 in T187869 ~April 2018
*Fuller history at https://www.mediawiki.org/wiki/Template:Compatibility_browser

@Amorymeltzer Amorymeltzer merged commit 18798af into wikimedia-gadgets:master Nov 30, 2019
@siddharthvp siddharthvp deleted the oldie branch October 22, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: config Module: twinkle The twinkle.js global gadget file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants